Retry connection on height mismatch #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Block count is literally a block counter, while block height is the height written in the block. For block zero the height is zero while we have one block in the chain and therefore the count is one. Persistent store operates with heights, therefore comparison should be adjusted by one. Signed-off-by: Roman Khimov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2474 +/- ##
==========================================
- Coverage 29.48% 29.47% -0.01%
==========================================
Files 399 399
Lines 30430 30433 +3
==========================================
- Hits 8971 8970 -1
- Misses 20715 20719 +4
Partials 744 744
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
carpawell
requested changes
Aug 7, 2023
roman-khimov
force-pushed
the
retry-conn-on-height-mismatch
branch
2 times, most recently
from
e2bfeae
to
b5f085b
Compare
We can have a set of RPC nodes configured and we will switch them in runtime, but if the first node is outdated then the IR node will _always_ fail to start until RPC node catches up. We can have a better behaviour with node switching to other RPCs in this phase. Can't be done this easily for the sidechain since in most cases we have an internal node and it needs to go through the chain completely. Refs. #2426. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
retry-conn-on-height-mismatch
branch
from
b5f085b
to
e3de08e
Compare
carpawell
approved these changes
Aug 8, 2023
cthulhu-rider
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.